triggered CI tests via

• https://github.com/OpenAPITools/openapi-generator/actions/runs/12443478387/job/34742694987?pr=20364
• https://github.com/OpenAPITools/openapi-generator/actions/runs/12443477103/job/34742692216?pr=20364

and both tests passed

Thanks @qiaojunfeng, I shall check this out this weekend.

The effect of this change would be that if something is specified as binary format, it would now be generated as a String instread of Vector{UInt8} bytearray. While strings in Julia can contain invalid UTF8 bytecodes (https://docs.julialang.org/en/v1/manual/strings/), canonically Vector{UInt8} is used for such purposes.

I would like to understand more the reason why you feel we should have this changed in the openapi generated code?

The effect of this change would be that if something is specified as binary format, it would now be generated as a String instread of Vector{UInt8} bytearray. While strings in Julia can contain invalid UTF8 bytecodes (https://docs.julialang.org/en/v1/manual/strings/), canonically Vector{UInt8} is used for such purposes.

I would like to understand more the reason why you feel we should have this changed in the openapi generated code?

Thanks @tanmaykm!
A concise answer to this is that with the current generator, the generated julia code does not work with binary string for file upload. Probably it is easier to understand this by running this example
https://github.com/qiaojunfeng/test-julia-OpenAPI/tree/main

Thanks @qiaojunfeng, I think the issue here is missing check for the isBinary flag in some places of the template. Should those be added instead of removing the check altogether? Then the code would be generated as Vector{UInt8} uniformly for binary strings and that should resolve the issue.

@qiaojunfeng Here's my recommended changes: https://github.com/OpenAPITools/openapi-generator/compare/master...tanmaykm:tan/fixfile?expand=1
If it works please feel free to update this PR with that.

@tanmaykm Thanks for the changes!

Indeed using Vector{UInt8} uniformly as the arg type feels cleaner, but unfortunately, it does not work for such cases.

The reason comes from these:

1. In the client part, the arg file::Vector{UInt8} is used to set the OpenAPI.Clients.Ctx.file, which has type file::Dict{String,String}, so it does not work

function _oacinternal_upload_post(_api::DefaultApi, file::Vector{UInt8}; _mediaType=nothing)
    _ctx = OpenAPI.Clients.Ctx(_api.client, "POST", _returntypes_upload_post_DefaultApi, "/upload", [])
    OpenAPI.Clients.set_param(_ctx.file, "file", file)  # type Vector{UInt8}
    ...

https://github.com/qiaojunfeng/test-julia-OpenAPI/blob/7bed81b4a84fbdb93f2fcaf951e31903b053bb08/client/src/apis/api_DefaultApi.jl#L47-L49
(Your tan/fixfile branch generates the same code as in this link (same as released version of openapi-generator))

2. When OpenAPI.jl prepares for uploading file, it internally uses curl_mime_filedata, and libcurl c interface expect it to be a filename not file content (https://curl.se/libcurl/c/curl_mime_filedata.html)

            for (_k,_v) in ctx.file
                part = LibCURL.curl_mime_addpart(mime)
                LibCURL.curl_mime_name(part, _k)
                LibCURL.curl_mime_filedata(part, _v)

https://github.com/JuliaComputing/OpenAPI.jl/blob/f18935ed12e40e56d007471e0690216e728e48b0/src/client.jl#L382-L385

Therefore, in my branch, I directly set file as String pointing to the filename, instead of the file content of type Vector{UInt8}

function _oacinternal_upload_post(_api::DefaultApi, file::String; _mediaType=nothing)
    _ctx = OpenAPI.Clients.Ctx(_api.client, "POST", _returntypes_upload_post_DefaultApi, "/upload", [])
    OpenAPI.Clients.set_param(_ctx.file, "file", file)  # type String

https://github.com/qiaojunfeng/test-julia-OpenAPI/blob/7bed81b4a84fbdb93f2fcaf951e31903b053bb08/client_new/src/apis/api_DefaultApi.jl#L47-L49

3. If we still want to use Vector{UInt8} as the type, probably we need to create a temp file, write the content to it, and pass the temp file name as _v to LibCURL.curl_mime_filedata(part, _v). Since in most cases the file content should be already stored some where as a file, maybe directly passing filename can avoid reading and writing again the content to a temp file, especially useful if the file size is large?